From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Mon, 10 Oct 2016 10:34:05 GMT
Subject: Re: [PATCH 2/2] files_read_raw_ref: prevent infinite retry loops in general
Message-ID: <d01fa7f9-827c-fc56-2d4d-69ba87ae851a@alum.mit.edu>
In-Reply-To: <20161006164842.yzrdigfimzvgkubv@sigill.intra.peff.net>

On 10/06/2016 06:48 PM, Jeff King wrote:
> Limit the number of retries to 3. That should be adequate to
> prevent any races, while preventing the possibility of
> infinite loops if the logic fails to handle any other
> possible error modes correctly.
> 
> After the fix in the previous commit, there's no known way
> to trigger an infinite loop, but I did manually verify that
> this fixes the test in that commit even when the code change
> is not applied.
> [...]

This patch is

Reviewed-by: Michael Haggerty <mhagger@alum.mit.edu>

Michael