From: D. Ben Knoble Date: Mon, 12 Oct 2026 17:48:26 GMT Subject: [PATCH 0/5] stash completion miscellany Message-ID: Hi all, This short patch series takes care of a few paper cuts in stash completion. The first patch is a small code cleanup I noticed a while back while working on bfc1b34859 (completion: add stash import, export, 2026-02-07), I think. The next 2 take care of a problem I've been having with Zsh's completion of stashes (cf. Unix & Linux SE [1]). [1]: https://unix.stackexchange.com/q/807580/301073 The final 2 are not only about completion; I noticed we were special-casing save completion, did some digging, and was a bit confused by the status of "git stash save". So, I figured while I was here I would start a conversation about (a) restoring the git-stash(1) manual to it's "no save" version and (b) ripping out the special case. These last 2 may be controversial, and I'm not particularly attached to them, so if they need to be dropped I won't really complain. OTOH, what's the point of a deprecated subcommand we still advertise? ;) Generated-with: git format-patch @{u}.. -o p [1/5] completion: simplify stash subcommand completion [2/5] completion: extract common stash listing code [3/5] completion: fix Zsh handling of stash names [4/5] doc: drop usage mentions of "git stash save" [5/5] completion: drop "stash save" completion altogether Documentation/git-stash.adoc | 2 -- builtin/stash.c | 1 - contrib/completion/git-completion.bash | 22 +++++++++++++--------- contrib/completion/git-completion.zsh | 5 +++++ 4 files changed, 18 insertions(+), 12 deletions(-) base-commit: 6de20f6092dcf9bdb1c8efe03db4b70c82b423dd -- 2.56.0.184.g5a00b4a6e9.dirty