From: Taylor Blau Date: Thu, 14 Nov 2024 13:42:05 GMT Subject: [PATCH v2 0/2] pack-objects: more brown-paper-bag multi-pack reuse fixes Message-ID: In-Reply-To: This is a small re-roll of my series to fix a regression in multi-pack reuse based on a broken assumption in write_reused_pack_verbatim(). The only change since last time is removing a stray debugging aid, and the series is otherwise identical as in v1. A range-diff is included below for convenience. Thanks in advance for your review! Taylor Blau (2): t5332-multi-pack-reuse.sh: demonstrate duplicate packing failure pack-objects: only perform verbatim reuse on the preferred pack builtin/pack-objects.c | 101 +++++++++++++++--------------------- t/t5332-multi-pack-reuse.sh | 22 ++++++++ 2 files changed, 65 insertions(+), 58 deletions(-) Range-diff against v1: 1: 7a69cf84ae5 ! 1: d791b7b20c9 t5332-multi-pack-reuse.sh: demonstrate duplicate packing failure @@ t/t5332-multi-pack-reuse.sh: test_expect_success 'duplicate objects' ' + + # ...and create a separate pack containing just that object + p="$(git pack-objects $packdir/pack