From: Mark Levedahl <mlevedahl@gmail.com>
Date: Wed, 30 Jul 2025 21:19:20 GMT
Subject: Re: [PATCH 5/5] git-gui: ensure own version of git-gui--askpass is used
Message-ID: <cf81b5f5-06a5-404c-9edd-e94b902aa455@gmail.com>
In-Reply-To: <ce964e5a-fe30-42da-bf8d-969893e3907f@kdbg.org>



On 7/30/25 3:04 PM, Johannes Sixt wrote:
> Am 30.07.25 um 18:40 schrieb Carlo Marcelo Arenas Belón:
>> Propagate the `git --exec-path` that is defined at build time
>> and use it when defining which askpass helper to use by default.
>>
>> This is specially useful in macOS where a broken version of that
>> helper is provided by the system git.
>>
>> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
>> ---
>

The expectation is that git-gui--askpass is colocated with git-gui, and not with git. This
directory is found at runtime as

   [file dirname [file normalize $::argv0]]]

It seems to me we could just put this into git-gui.sh instead of [git --exec-path], and
the patch is much simpler.

Mark