From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Wed, 11 Oct 2017 08:30:40 GMT
Subject: Re: [PATCH v2 23/24] refs: convert read_raw_ref backends to struct object_id
Message-ID: <cebd6976-833e-ebb4-ef90-445e3b338d36@alum.mit.edu>
In-Reply-To: <20171009011132.675341-24-sandals@crustytoothpaste.net>

On 10/09/2017 03:11 AM, brian m. carlson wrote:
> Convert the unsigned char * parameter to struct object_id * for
> files_read_raw_ref and packed_read_raw-ref.  Update the documentation.

Nit:

s/packed_read_raw-ref/packed_read_raw_ref/

> Switch from using get_sha1_hex and a hard-coded 40 to using
> parse_oid_hex.
> [...]

Michael