From: Jameson Miller <jameson.miller81@gmail.com>
Date: Thu, 12 Oct 2017 20:20:37 GMT
Subject: Re: [PATCH v2 0/5] Teach Status options around showing ignored files
Message-ID: <cdf54fae-806e-c5b7-4420-da66bfcd196a@gmail.com>
In-Reply-To: <xmqq60bl2iyp.fsf@gitster.mtv.corp.google.com>



On 10/11/2017 10:33 PM, Junio C Hamano wrote:
> Jameson Miller <jameson.miller81@gmail.com> writes:
>
>> Changes in v2:
>>
>> Addressed review comments from the original series:
>>
>> * Made fixes / simplifications suggested for documentation
>>
>> * Removed test_tick from test scripts
>>
>> * Merged 2 commits (as suggested)
>>
>> Jameson Miller (5):
>>    Teach status options around showing ignored files
>>    Update documentation for new directory and status logic
>>    Add tests for git status `--ignored=matching`
>>    Expand support for ignored arguments on status
>>    Add tests around status handling of ignored arguments
> Please make sure these titles mix well when they appear together
> with changes from other people that are completely unrelated to
> them.  Keep in mind that your "git status" is *not* the most
> important thing in the world (of course, it is no less important
> than others, either).  Perhaps
>
>      status: add new options to show ignored files differently
>      status: document logic to show new directory
>      status: test --ignored=matching
Thank you for the suggestions - I will update the  commit titles in my 
next round.
>
> etc.  Rules of thumb:
>
>   (1) choose "<area>: " prefix appropriately
>   (2) keep them short and to the point
>   (3) word that follow "<area>: " prefix is not capitalized
>   (4) no need for full-stop at the end of the title
>
>