From: Franck Bui-Huu <vagabon.xyz@gmail.com>
Date: Sat, 09 Sep 2006 14:38:13 GMT
Subject: Re: [PATCH 2/4] git-archive: wire up TAR format.
Message-ID: <cda58cb80609090738p239c7359pfd0be092d93ed657@mail.gmail.com>
In-Reply-To: <4501D0CF.70306@lsrfire.ath.cx>

2006/9/8, Rene Scharfe <rene.scharfe@lsrfire.ath.cx>:
> Franck Bui-Huu schrieb:
> > From: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
> >
> > Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
> > Signed-off-by: Franck Bui-Huu <vagabon.xyz@gmail.com>
>
> I did not sign off this exact patch.  I wrote and submitted the
> builtin-tar-tree.c part, with memory leak and all, then sent a note
> on where the leak needs to be plugged.  You put it together and
> converted it to struct archiver_args.  I'd very much have liked to
> see a comment stating this.  Or simply just say "based on code by
> Rene" or something.  The same is true for patch 3/4.
>

OK I'll change that....

> > ---
> >  extern void parse_pathspec_arg(const char **pathspec,
> >                              struct archiver_args *args);
> > +/*
> > + *
> > + */
>
> Especially I would not have signed off this invisible comment. ;)
>
> René
>

and put something usefull here.

Thanks
-- 
               Franck