From: Jan Alexander Steffens (heftig) <heftig@archlinux.org>
Date: Wed, 22 Nov 2023 09:50:44 GMT
Subject: Re: [PATCH v2 1/6] submodule--helper: use submodule_from_path in set-{url,branch}
Message-ID: <ccbab7a73f734b09fb6915ab30506eb2c0db2321.camel@archlinux.org>
In-Reply-To: <xmqq4jhedxza.fsf@gitster.g>

On Wed, 2023-11-22 at 16:54 +0900, Junio C Hamano wrote:
> "Jan Alexander Steffens (heftig)" <heftig@archlinux.org> writes:
> 
> > Notes:
> >     v2 changes:
> >         - fixed code style
> >         - replaced potentially unsafe use of `sub->path` with
> > `path`
> 
> Hasn't the previous iteration of this topic long been merged to not
> just 'next' but to 'master' and appears in a released version of Git?
> 
> We are all human, so mistakes are inevitable, but if we discover a
> mistake that needs fixing after a topic hits 'next', we take it as a
> sign that the particular mistake was easy to make and hard to spot,
> and the fix for it deserves its own explanation.  Please make an
> incremental update on top of what has already been merged with a
> good explanation (explain why sub->path is "potentially unsafe" and
> why using path is better, for example).
> 
> Thanks.

So it has. I'm sorry. I was only keeping track of the 'maint' branch.