From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Wed, 24 Feb 2010 23:11:05 GMT
Subject: Re: [PATCHv4 1/6] environment: static list of repo-local env vars
Message-ID: <cb7bb73a1002241511w1ed2e5e7pbc4565b81a6a1039@mail.gmail.com>
In-Reply-To: <7vocjemnnq.fsf@alter.siamese.dyndns.org>

On Wed, Feb 24, 2010 at 8:36 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:
>
>> On Wed, Feb 24, 2010 at 4:58 PM, Junio C Hamano <gitster@pobox.com> wrote:
>>> Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:
>>>
>>>> +/* Repository-local GIT_* environment variables */
>>>> +const char *const local_repo_env[] = {
>>>> +     ALTERNATE_DB_ENVIRONMENT,
>>>> +     CONFIG_ENVIRONMENT,
>>>> +     DB_ENVIRONMENT,
>>>> +     GIT_DIR_ENVIRONMENT,
>>>> +     GIT_WORK_TREE_ENVIRONMENT,
>>>> +     GRAFT_ENVIRONMENT,
>>>> +     INDEX_ENVIRONMENT,
>>>> +     NO_REPLACE_OBJECTS_ENVIRONMENT,
>>>> +     NULL
>>>> +};
>>>> +
>>>> +const unsigned int local_repo_env_size = ARRAY_SIZE(local_repo_env);
>>>
>>> This does not look very useful for two reasons.
>
> By the way, I said "frustrating" but didn't mean we should bend backwards.
> The earlier one is more than Ok, and is certainly better than having
> local_repo_env_size that is not very useful in practice.

But I'd like a manually-set local_repo_env_size than the gimmicks
necessary if it's not there (plus the runtime failure). If there are
no other corrections, I'll send a new series (that also squashes the
first two patches per Johannes' suggestion) and the #define

-- 
Giuseppe "Oblomov" Bilotta