From: Giuseppe Bilotta Date: Tue, 23 Feb 2010 22:54:40 GMT Subject: Re: git gui create desktop icon currently does not work Message-ID: In-Reply-To: <20100223224955.GB11271@book.hvoigt.net> On Tue, Feb 23, 2010 at 11:49 PM, Heiko Voigt wrote: > Hi, > > I have a patch (further down) to this issue but I only tested this on > Windows 7 and my virtual machine (XP) did not like it for some reason (it > created the shortcut but the shortcut did not work). If anyone else can > confirm that this patch actually works we can include it. > > Commit 3748b0 git-gui: update shortcut tools to use _gitworktree > from Guiseppe does break the creation of Desktop shortcuts on Windows. > > I do not know whether this has worked with any tcl interpreter as it > attempts to execute $_gitworktree as a command. > > Here is my fix: > > From 5c22c39d530ffb308826629d974048d30cd32e53 Mon Sep 17 00:00:00 2001 > From: Heiko Voigt > Date: Tue, 23 Feb 2010 10:40:14 +0100 > Subject: [PATCH 1/2] git-gui: fix usage of _gitworktree when creating shortcut for windows > > Signed-off-by: Heiko Voigt > --- >  git-gui/lib/shortcut.tcl |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/git-gui/lib/shortcut.tcl b/git-gui/lib/shortcut.tcl > index 79c1888..8cad0e2 100644 > --- a/git-gui/lib/shortcut.tcl > +++ b/git-gui/lib/shortcut.tcl > @@ -16,7 +16,7 @@ proc do_windows_shortcut {} { >                                        [info nameofexecutable] \ >                                        [file normalize $::argv0] \ >                                        ] \ > -                                       [file normalize [$_gitworktree]] > +                                       [file normalize $_gitworktree] >                        } err]} { >                        error_popup [strcat [mc "Cannot write shortcut:"] "\n\n$err"] >                } Ouch. Yes, I think your patch is obviously correct. (I'll go sit in a corner with my 'TCL Dunce' cap on for a while ...) -- Giuseppe "Oblomov" Bilotta