From: Giuseppe Bilotta Date: Tue, 23 Feb 2010 07:55:45 GMT Subject: Re: [PATCH 1/2] shell setup: clear_local_git_env() function Message-ID: In-Reply-To: <4B837A73.8010406@viscovery.net> On Tue, Feb 23, 2010 at 7:49 AM, Johannes Sixt wrote: > Giuseppe Bilotta schrieb: >> +# Clear repo-local GIT_* environment variables. Useful when switching to >> +# another repository (e.g. when entering a submodule) >> +clear_local_git_env() { >> +     unset   GIT_DIR GIT_WORKTREE GIT_OBJECT_DIRECTORY \ >> +             GIT_INDEX_FILE GIT_GRAFT_FILE GIT_CONFIG \ >> +             GIT_NO_REPLACE_OBJECTS > > IMO, this list should be in sync with the one you find in > connect.c:git_connect() around line 611. They have the same purpose. Ah, interesting, I was looking for such a list but only found the more generic one in cache.h By comparing them it would seem they serve the same purpose, indeed. I notice that the connect.c is missing GIT_CONFIG (which _must_ be unset for us). I also notice that the connect.c one unsets the alternate DB; I had doubts about it when preparing the list in this case. I will resend a new patch to replace this one, syncing the two lists. > (And, BTW, a vertical list would be more readable than a mixed > horizontal+vertical list, IMVHO.) I tend to conserve vertical space, but I have no particular objection to that. -- Giuseppe "Oblomov" Bilotta