From: Giuseppe Bilotta Date: Tue, 30 Jun 2009 20:52:26 GMT Subject: Re: [PATCHv8 5/7] gitweb: gravatar url cache Message-ID: In-Reply-To: <7vprcl78zm.fsf@alter.siamese.dyndns.org> On Tue, Jun 30, 2009 at 10:38 PM, Junio C Hamano wrote: > Giuseppe Bilotta writes: > >> +# Rather than recomputing the url for an email multiple times, we cache it >> +# after the first hit. This gives a visible benefit in views where the avatar >> +# for the same email is used repeatedly (e.g. shortlog). >> +# The cache is shared by all avatar engines (currently gravatar only), which >> +# are free to use it as preferred. Since only one avatar engine is used for any >> +# given page, there's no risk for cache conflicts. > > Is it "any given page", or "any given e-mail"? It's 'page' as in HTML file served by the script. I couldn't find a better way to express that. -- Giuseppe "Oblomov" Bilotta