From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Sun, 28 Jun 2009 16:03:58 GMT
Subject: Re: [PATCHv7 7/9] gitweb: picon avatar provider
Message-ID: <cb7bb73a0906280903y3175712bx6923b179a9789a1d@mail.gmail.com>
In-Reply-To: <200906281335.40312.jnareb@gmail.com>

2009/6/28 Jakub Narebski <jnareb@gmail.com>:
> Thoughts for the possible future enhancements: find final URL of an image
> via http://www.cs.indiana.edu/cgi-pub/kinzler/piconsearch.cgi/$domain/$user/users+domains+unknown/up/off/1/order
> by scrapping (parsing) it for .gif link, and store this URL in cache.
> But that most probably isn't worth it.  Just feel like mentioning it.

That was my first thought, but since piconsearch offers a link
directly, I decided it was much better to use that rather than html
scraping.

> Should it be stated that <img width="$size" ...> is here because not
> all kinds of avatars (not all avatar providers) support selecting size
> of avatar, somewhere in this comment?

It is generally good form to have the size specified in advance in
HTML anyway, which is why on later iterations I put the width spec in
the first avatar service commit.

-- 
Giuseppe "Oblomov" Bilotta