From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Thu, 25 Jun 2009 13:15:00 GMT
Subject: Re: [PATCHv6 0/8] gitweb: gravatar support
Message-ID: <cb7bb73a0906250615i2ed880eci2d3716aa1ca43e4d@mail.gmail.com>
In-Reply-To: <200906251455.32953.jnareb@gmail.com>

2009/6/25 Jakub Narebski <jnareb@gmail.com>:
> Giuseppe Bilotta wrote:
>
>> Significant changes from the previous iteration are:
>>
>> * the feature has been renamed to 'avatar', and 'gravatar' is a possible
>>   value for it (currently the only sensible value, other than '');
>
> By the way, I think it might be better solution to provide picon URL
> as 'default' attribute for gravatar URL, so it is used if there is no
> gravatar for given email.

I was thinking about some form of fallback like that too, but I
haven't the slightest idea how picons work, so I'm afraid I'll leave
that enhancement to some later time.

>> * the last patch adds avatars to signoff lines.
>
> Perhaps it would be better to add gravatars at beginning of line?

I'm not sure. As I mention in the email for that commit, I'm totally
not satisfied with the layout. I'm lookint into turning signoff blocks
into tables.

> I'll try to post my comments today (i.e. within 24 hours)... but it
> looks good.

Thanks a lot.

-- 
Giuseppe "Oblomov" Bilotta