From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Sun, 24 May 2009 23:03:38 GMT
Subject: Re: [PATCH 0/2] StGit patch series import
Message-ID: <cb7bb73a0905241603r4949abb5g1a9e861aba40c6fe@mail.gmail.com>
In-Reply-To: <fabb9a1e0905241557l403037f6p7c1df1f587cb9cf7@mail.gmail.com>

On Mon, May 25, 2009 at 12:57 AM, Sverre Rabbelier <srabbelier@gmail.com> wrote:
> Heya,
>
> On Mon, May 25, 2009 at 00:53, Giuseppe Bilotta
> <giuseppe.bilotta@gmail.com> wrote:
>> This is an interesting solution. And git-am could call git-munge
>> automatically before feeding the patches to mailinfo, replacing
>>  git mailinfo $keep $utf8 "$dotest/msg" "$dotest/patch" \
>>      <"$dotest/$msgnum" >"$dotest/info"
>> with
>>  git munge "$dotest/$msgnum" | git mailinfo etc
>
> I was thinking the other way around, so that 'git am' doesn't need to
> be modified.
>
> Behind the scenes, git munge "$dotest/$msgnum" does something like:
> 1. munge the file so that it's in the appropriate format
> 2. dispatch to 'git am' with the munged file
> 3. profit

But then the name munge would not be descriptive of what the command
does. If git am is to be left untouched, I would rather then have
something like git import-patches that accepts patches in 'any'
format, expanding StGIT series into the respective patches and
transforming everything into mbox format, invoking am on the final
result. But I see no particular reason why git-am shouldn't be able to
handle all this by itself


-- 
Giuseppe "Oblomov" Bilotta