From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Fri, 06 Feb 2009 11:03:26 GMT
Subject: Re: [PATCHv2 3/6] gitweb: rss feed managingEditor
Message-ID: <cb7bb73a0902060303s35527b3ey8572d60c54066e33@mail.gmail.com>
In-Reply-To: <200902050019.44016.jnareb@gmail.com>

On Thu, Feb 5, 2009 at 12:19 AM, Jakub Narebski <jnareb@gmail.com> wrote:
> On Mon, 26 Jan 2009, Giuseppe Bilotta wrote:
>
>> The RSS 2.0 specification allows an optional managingEditor tag for the
>> channel, containing the "email address for person responsible for editorial
>> content", which is basically the project owner.
>
> Hmmm... does it make sense with gitweb? Perhaps it does...

I must confess I had my own doubts about this 8-D

>> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
>> ---
>>  gitweb/gitweb.perl |    4 +++-
>>  1 files changed, 3 insertions(+), 1 deletions(-)
>>
>> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
>> index 3d94f50..cc6d0fb 100755
>> --- a/gitweb/gitweb.perl
>> +++ b/gitweb/gitweb.perl
>> @@ -6074,7 +6074,9 @@ XML
>>               print "<title>$title</title>\n" .
>>                     "<link>$alt_url</link>\n" .
>>                     "<description>$descr</description>\n" .
>> -                   "<language>en</language>\n";
>> +                   "<language>en</language>\n" .
>> +                   # project owner is responsible for 'editorial' content
>> +                   "<managingEditor>$owner</managingEditor>\n";
>
> Shouldn't we esc_html($owner), just in case it is for example
> "O Wner <owner@example.com>" (either via gitweb.owner or via
> projects_index being text file listing projects, because I don't
> see GECOS having email in it...)?
>

Indeed, itt's probably safer to do the escaping.


-- 
Giuseppe "Oblomov" Bilotta