From: Giuseppe Bilotta Date: Wed, 03 Dec 2008 20:52:00 GMT Subject: Re: [RFCv2 1/2] gitweb: add patch view Message-ID: In-Reply-To: <200812031808.01916.jnareb@gmail.com> On Wed, Dec 3, 2008 at 6:08 PM, Jakub Narebski wrote: > On Wed, Dec 3, 2008 at 14:14, Giuseppe Bilotta wrote: >> >> The way it's implemented in v2, you just need to set $patch_max in >> your local or system config file (e.g. /etc/gitweb.conf). I'm not sure >> about the benefit we would gain in going through %feature. > > Ah, I haven't read patch in detail yet. > > The (doubtful or not) benefit of going through %feature would be ability > to set limits (with perhaps -1 / <0 / undef / '' meaning: unlimited) on > per repository basis, with no limit for small repository, some limit for > the rest, and no 'patch' view or heavily limited for repository with > large size commits. Hm. I'm not entirely sure it would be used at all, but I think this could be done. Something like the following: * perl false meaning: feature disabled * > 0 maximum number of patches * does Perl have an 'infinity' value? if not, we can use <0 to mean unlimited -- Giuseppe "Oblomov" Bilotta