From: Giuseppe Bilotta Date: Sat, 29 Nov 2008 22:27:40 GMT Subject: Re: [PATCH 3/3] gitweb: make gitweb_check_feature a boolean wrapper Message-ID: In-Reply-To: <7vmyfiz0zf.fsf_-_@gitster.siamese.dyndns.org> On Sat, Nov 29, 2008 at 10:16 PM, Junio C Hamano wrote: > * Again, this is to demonstrate how I would have liked to see your > patches as a reviewable series. Notice how this naturally justifies > the dropping of parentheses in many lines that begin with "my", and > makes it easier to review? You can review the patch easily by knowing > that callers that have s/get/check/ are now safe to use scalar context. Yes, I get the point: do less things under the hood. I also still think that three patches with code going ping-pong are way too much, though 8-P For what it's worth, you get my Ack: to your patchset 8-) -- Giuseppe "Oblomov" Bilotta