From: Giuseppe Bilotta Date: Sat, 29 Nov 2008 22:16:29 GMT Subject: Re: [PATCHv2ter 2/2] gitweb: clean up gitweb_check_feature() calls Message-ID: In-Reply-To: <7vzljiz1qn.fsf@gitster.siamese.dyndns.org> On Sat, Nov 29, 2008 at 10:00 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >> ... The change is not >> about fixing (your proposed commit log message read "gitweb:fixes to >> gitweb feature check code") as nothing is broken. It is purely about >> futureproofing and I think we should mark it as such. > > Actually, there is a handful clueless/careless callers. Before applying > any of the check => get patch, let's do this as a fix. And this is precisely the reason why the first time I sent the patch I did the restyling in the same go: by not touching the clueless/careless callers and instead bringing gitweb_check_feature to act in scalar context, it would automatically fix those broken usages, and it made sense to convert all array-to-get-a-scalar assignmets as well. -- Giuseppe "Oblomov" Bilotta