From: Giuseppe Bilotta Date: Sun, 16 Nov 2008 15:30:33 GMT Subject: Re: [PATCH] gitweb: fixes to gitweb feature check code Message-ID: In-Reply-To: <1226759165-6894-1-git-send-email-giuseppe.bilotta@gmail.com> Forgot the sign-off line On Sat, Nov 15, 2008 at 3:26 PM, Giuseppe Bilotta wrote: > The gitweb_check_feature routine was being used for two different > purposes: retrieving the actual feature value (such as the list of > snapshot formats or the list of additional actions), and to check if a > feature was enabled. > > For the latter use, since all features return an array, it led to either > clumsy code or subtle bugs, with disabled features appearing enabled > because (0) evaluates to 1. > > We fix these bugs, and simplify the code, by separating feature (list) > value retrieval (gitweb_get_feature) from boolean feature check (i.e. > retrieving the first/only item in the feature value list). Usage of > gitweb_check_feature across gitweb is replaced by the appropriate call > wherever needed. Signed-off-by: Giuseppe Bilotta -- Giuseppe "Oblomov" Bilotta