From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Fri, 10 Oct 2008 17:33:40 GMT
Subject: Re: [PATCHv2] gitweb: refactor input parameters parse/validation
Message-ID: <cb7bb73a0810101033y3741df2dy88a64e72cbc3b8b0@mail.gmail.com>
In-Reply-To: <20081010150108.GC29829@spearce.org>

On Fri, Oct 10, 2008 at 5:01 PM, Shawn O. Pearce <spearce@spearce.org> wrote:
> Giuseppe Bilotta <giuseppe.bilotta@gmail.com> wrote:
>> +sub validate_action {
>> +     my $input = shift || return undef;
>> +     return undef unless exists $actions{$action};
>> +     return $action;
>> +}
>
> Shouldn't $action here be $input?

Urgh. Yes, yes it should. Good catch. Should I resend?


-- 
Giuseppe "Oblomov" Bilotta