From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Mon, 29 Sep 2008 14:12:28 GMT
Subject: Re: [PATCH 2/6] gitweb: use_pathinfo filenames start with /
Message-ID: <cb7bb73a0809290712g324ec015r70fd868b91673645@mail.gmail.com>
In-Reply-To: <200809290308.09312.jnareb@gmail.com>

On Mon, Sep 29, 2008 at 3:08 AM, Jakub Narebski <jnareb@gmail.com> wrote:
> On Sun, 21 Sep 2008, Giuseppe Bilotta wrote:
>
>> When using path info, make filenames start with a / (right after the :
>> that separates them from the hash base). This minimal change allows
>> relative navigation to work properly when viewing HTML files.
>
> Good idea. Nitpick: instead of "using path info", perhaps "generating
> path info URL"; this change is about gitweb link generation...

Right.

> Did you check if gitweb strips leading '/' from filename?

Yes.

>> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
>> ---
>>  gitweb/gitweb.perl |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
>> index e783d12..18da484 100755
>> --- a/gitweb/gitweb.perl
>> +++ b/gitweb/gitweb.perl
>> @@ -664,7 +664,7 @@ sub href (%) {
>>               if (defined $params{'hash_base'}) {
>>                       $href .= "/".esc_url($params{'hash_base'});
>>                       if (defined $params{'file_name'}) {
>> -                             $href .= ":".esc_url($params{'file_name'});
>> +                             $href .= ":/".esc_url($params{'file_name'});
>>                               delete $params{'hash'} if $params{'hash'} eq git_get_hash_by_path($params{'hash_base'},$params{'file_name'});
>>                               delete $params{'file_name'};
>>                       } else {
>> --
>> 1.5.6.5
>
> Is there reason why this change is separate (not squashed) from
> previous commit?

Historical reason (i.e. I came up with the idea later on). I'll squash it.

-- 
Giuseppe "Oblomov" Bilotta