From: Giuseppe Bilotta Date: Mon, 29 Sep 2008 13:05:16 GMT Subject: Re: [PATCH 5/6] gitweb: remove PATH_INFO from $my_url and $my_uri Message-ID: In-Reply-To: <200809291033.34588.jnareb@gmail.com> On Mon, Sep 29, 2008 at 10:33 AM, Jakub Narebski wrote: > On Sun, 21 Sep 2008, Giuseppe Bilotta wrote: > >> This patch (combined with appropriate server configuration) allows usage >> of the gitweb CGI script as DirectoryIndex for the server root even when >> the pathinfo feature is enabled. >> > > This is IMHO a bugfix for a path_info handling bug, for which there > was an ugly workaround of specifying base URL ($my_url and $my_uri) > explicitly in gitweb configuration (GITWEB_CONFIG). > > Therefore I think that this patch should have been sent outside of > the rest of "new path_info features" series, as a separate single > patch, and now that it is there it really should be applied, perhaps > even to the 'maint' branch. Ok, I'll resend it separately, with the suggested fix. -- Giuseppe "Oblomov" Bilotta