From: Mark Lodato <lodatom@gmail.com>
Date: Sun, 28 Feb 2010 20:39:31 GMT
Subject: Re: [PATCH 4/5] grep: Colorize filename, line number, and separator
Message-ID: <ca433831002281239j2fc17033xfa013bf896dcda2c@mail.gmail.com>
In-Reply-To: <7vd3zp88gn.fsf@alter.siamese.dyndns.org>

On Sun, Feb 28, 2010 at 2:29 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Mark Lodato <lodatom@gmail.com> writes:
>
>> +color.grep.<slot>::
>> +     Use customized color for grep colorization.  `<slot>` specifies which
>> +     part of the line to use the specified color, and is one of
>> ++
>> +--
>> +`filename`:::
>> +     filename prefix (when not using `-h`)
>> +`linenumber`:::
>
> Why do I get a feeling that I already said something about three colons?
>
>  ... goes and looks ...
>
> Ah, it wasn't to you.  Please see:
>
>  http://thread.gmane.org/gmane.comp.version-control.git/139014/focus=139343
>
> BUT.
>
> I tried the three-colons notation with AsciiDoc 8.2.7 and it seems to take
> it as enumeration items that are nested a level deeper, so this might be
> safe.

When I wrote the patch originally, I tried to find the difference
between triple colons and double semi-colons but failed.  Now that I
look at the changelog, double semi-colons was introduced in 5.0.9, but
there is no indication whatsoever of triple colons.  The wording
implies that double-semicolon is older, so it's probably safer to use.
 I'll switch to that.

> But the last sentence about color.branch.<slot> is indented as if it is a
> part of description for "separator" slot, which you may want to fix
> regardless.
>

Man!  It worked in AsciiDoc 8.4.4, but evidently not in 8.2.7.  What a
pain.  I just installed 8.2.7 so hopefully I won't run into these
problems in the future.  I'll fix this.