From: Derrick Stolee <stolee@gmail.com>
Date: Mon, 11 Dec 2017 14:05:26 GMT
Subject: Re: [PATCH] builtin/tag.c: return appropriate value when --points-at finds an empty list
Message-ID: <ca421d38-2d9a-8681-7947-3799c59984a7@gmail.com>
In-Reply-To: <20171211134409.13339-1-g3orge.app@gmail.com>

On 12/11/2017 8:44 AM, George Papanikolaou wrote:
> `git tag --points-at` can simply return if the given rev does not have
> any tags pointing to it. It's not a failure but it shouldn't return
> with 0 value.

I disagree. I think the 0 return means "I completed successfully" and 
the empty output means "I didn't find any tags pointing to this object."

Changing the return value here could break a lot of scripts out in the 
wild, and I consider this to be an "API" compatibility that needs to 
stay as-is.

What are you using "--points-at" where you need a nonzero exit code 
instead of a different indicator?

Thanks,
-Stolee