From: Jeff Hostetler Date: Mon, 08 May 2017 20:18:31 GMT Subject: Re: [PATCH v7] read-cache: force_verify_index_checksum Message-ID: In-Reply-To: On 5/8/2017 4:03 PM, Christian Couder wrote: > On Mon, May 8, 2017 at 6:50 PM, Jeff Hostetler wrote: >> >> >> On 5/8/2017 5:45 AM, Christian Couder wrote: >>> >>> This test does not pass when the GIT_TEST_SPLIT_INDEX env variable is >>> set on my Linux machine. >>> >>> Also it looks like you sent a v8 of this patch series with a different >>> test, but what is in master looks like the above test instead of the >>> test in your v8. >> >> There was concern about using sed on a binary file not being portable >> and a request to change the test to just corrupt the checksum rather >> than an index-entry, so I changed it in v8. >> >> Does the v8 version of the test also fail on your machine ? > > The v8 version of the test succeeds on my machine. OK, thanks. It worked on mine too. Since the v8 version is a better test, I'm content to stick with it and not try to address the problem with the previous version. Jeff