From: Rubén Justo <rjusto@gmail.com>
Date: Mon, 15 Apr 2024 17:03:35 GMT
Subject: Re: [PATCH v4] launch_editor: waiting message on error
Message-ID: <c9f3b358-bce0-41dd-b717-e845f0b2dab3@gmail.com>
In-Reply-To: <beebf170-31d0-4ecf-b029-d6bc499f6da8@gmail.com>

On Mon, Apr 15, 2024 at 03:05:32PM +0100, Phillip Wood wrote:

> > However, it is possible that the editor exits with an error status, in
> > which case we show an error message and then return to our caller.  In
> > such a case, the error message is given where the terminal cursor
> > happens to be, which is most likely after the "we are waiting for your
> > editor" message on the same line.
> 
> As I've said before I'm not sure how likely that is as I think the editor
> will probably have printed a message if there was an error.

For instance, Vim with ":cq" does not emit any error message.

> Assuming the
> message from the editor ends with a newline the proposed change wont do any
> harm so I don't object to it.

Thanks.