From: Philippe Blain <levraiphilippeblain@gmail.com>
Date: Fri, 16 Jul 2021 01:28:00 GMT
Subject: Re: [PATCH] parse-options: don't complete option aliases by default
Message-ID: <c8322c37-38da-bde7-9361-adb68834b7d1@gmail.com>
In-Reply-To: <60f06a8a8e611_4b68208a9@natae.notmuch>

Hi Felipe,

Le 2021-07-15 à 13:04, Felipe Contreras a écrit :
> Philippe Blain via GitGitGadget wrote:
>> From: Philippe Blain <levraiphilippeblain@gmail.com>
>>
>>
>> Helpfully, since 64cc539fd2 (parse-options: don't leak alias help
>> messages, 2021-03-21) these copies have the PARSE_OPT_FROM_ALIAS flag
>> set, so check that flag early in 'show_gitcomp' and do not print them,
> 
> Makes sense but I don't think what the patch is doing should be buried
> here. I think a separate paragraph explaining what you are trying to do
> will be better.

Indeed. Will clarify.


> 
> I agree this is better, and the patch itself looks obviously correct.
> 
> Reviewed-by: Felipe Contreras <felipe.contreras@gmail.com>
> 

Thanks!

Philippe.