From: Victoria Dye Date: Thu, 13 Apr 2023 21:38:53 GMT Subject: Re: [PATCH v7 0/2] diff-files: integrate with sparse index Message-ID: In-Reply-To: Junio C Hamano wrote: > Shuqi Liang writes: > >> Changes since v6: >> >> 1. Fix word wrap in commit message. >> >> 2. Use 'mkdir -p folder1' since full-checkout already have folder1. >> >> 3. Use `--stat` to ignore file creation time differences in unrefreshed >> index. >> >> 4. In 'diff-files with pathspec outside sparse definition' add >> 'git diff-files "folder*/a" to show that the result is the same with a >> wildcard pathspec. >> >> 5. Create an 'ensure_expanded' to handle silent failures. > > It seems that review comments have petered out. > > Shall we mark this ready for 'next'? Sorry for the delay - I noticed a couple more things that might warrant changes before moving to 'next' and am in the process of writing up that response. I'll send it within the hour. > > Thanks.