From: Nick Edelen Date: Tue, 08 Sep 2009 22:24:22 GMT Subject: Re: [PATCH 5/6 (v4)] full integration of rev-cache into git, completed test suite Message-ID: In-Reply-To: <1252357564.5969.4.camel@maia.lan> > ^^ You don't need to write comments like "This patch"; in the history > such words are meaningless. I had meant to delete that... > "tweak" ? Yeah I had modified the messages and didn't replace the additional info I deleted. It's not really important, as it's modified again (for the last time) in the name-related patch, but here it's revised to take advantage of the size storage. >>  - more fluid handling of damaged cache slices > > What does this mean? That it remembers/is aware of bad slices, instead of dumbly attempting to load them upon each commit. > This is quite a long commit message.  Is the above detail all useful? > Can it be split into one patch for each of the above integrations? Erm, I suppose they could be split, but the changes to revision and list-objects aren't very big, so I figured it'd be easier/cleaner to just put everything required for smooth integration into a single patch. I dunno, it dosn't seem hugely necessary; the bits modifying git code are relatively small and already obviously seperate in the patch.