From: Ben Peart <peartben@gmail.com>
Date: Mon, 21 May 2018 12:36:06 GMT
Subject: Re: [PATCH 3/5] query_fsmonitor: use xsnprintf for formatting integers
Message-ID: <c5d9da23-447d-2878-cf4f-e9e7f12ce35f@gmail.com>
In-Reply-To: <cd6dba3c-19bb-e6c7-0c1f-5cea0c8f9d81@web.de>



On 5/19/2018 4:27 AM, René Scharfe wrote:
> Am 19.05.2018 um 03:57 schrieb Jeff King:
>> These formatted integers should always fit into their
>> 64-byte buffers. Let's use xsnprintf() to add an assertion
>> that this is the case, which makes auditing for other
>> unchecked snprintfs() easier.
> 
> How about this instead?
> 
> -- >8 --
>   
> -	snprintf(ver, sizeof(ver), "%d", version);
> -	snprintf(date, sizeof(date), "%" PRIuMAX, (uintmax_t)last_update);
> -	argv[1] = ver;
> -	argv[2] = date;
> -	argv[3] = NULL;
> -	cp.argv = argv;
> +	argv_array_push(&cp.args, core_fsmonitor);
> +	argv_array_pushf(&cp.args, "%d", version);
> +	argv_array_pushf(&cp.args, "%" PRIuMAX, (uintmax_t)last_update);

Looks good.  Simpler, cleaner, less error prone.

>   	cp.use_shell = 1;
>   	cp.dir = get_git_work_tree();
>   
>