From: Bagas Sanjaya Date: Tue, 21 Sep 2021 07:41:23 GMT Subject: Re: [PATCH RESEND] difftool: word spacing fix Message-ID: In-Reply-To: On 21/09/21 04.26, David Aguilar wrote: > But!.. and this is a big but... the po/ translations would be broken > by this change. > > I'm unfamiliar with the policy about changes that affect translations, > but in general this seems like a situation where we can make things > easier for the translation team by not leaving behind further work. > > My gut feeling is that this patch would be easier to accept if it also > updated the po/ translations to fix these typofixes. > > Question for this list -- would that be a separate patch or not? To me > it seems like it'd all be one patch so that git is never in an > in-between state. > I think you should see po/README for details. In other words: we can change translatable strings here as we want, and it's the responsibility of l10n teams to update translations to stay up to date. > The following commands show a few places of interest that should also > be updated. > > $ git grep 'combined diff formats(' > $ git grep 'tool returns a non - zero' I git-grep-ed that, and nothing outside po/ matched. -- An old man doll... just what I always wanted! - Clara