From: Phillip Wood <phillip.wood@talktalk.net>
Date: Tue, 15 Jan 2019 16:09:17 GMT
Subject: Re: [PATCH 6/7] Git.pm: introduce environment variable GIT_TEST_PRETEND_TTY
Message-ID: <c3daa35c-5242-65f8-15ab-9b520812438f@talktalk.net>
In-Reply-To: <nycvar.QRO.7.76.6.1901151448570.41@tvgsbejvaqbjf.bet>

On 15/01/2019 13:50, Johannes Schindelin wrote:
> Hi Phillip,
> 
> On Mon, 14 Jan 2019, Phillip Wood wrote:
> 
>> Hi Salvica/Johannes
> 
> Close ;-)

Sorry Slavica

> 
>> On 20/12/2018 12:09, Slavica Djukic via GitGitGadget wrote:
>>> From: Slavica Djukic <slawica92@hotmail.com>
>>>
>>> To enable testing the colored output on Windows, enable TTY
>>> by using environment variable GIT_TEST_PRETEND_TTY.
>>>
>>> This is the original idea by Johannes Schindelin.
>>
>> I normally use GIT_PAGER_IN_USE=1 to force colored output, is there some
>> reason that does not work here?
> 
> As Slavica found out, you need to set `TERM`, too, for that to work. And
> even then, it is more of a "happens to do what we want" rather than a
> "this is what we want to happen"...
> 
> But I'm fine either way, the color code does not really *need* more
> complexity, as it were...

Thanks for explaining, I didn't know the TERM needed to be set as well. 
If GIT_PAGER_IN_USE=1 works then maybe it is better to avoid adding any 
more complexity.

Best Wishes

Phillip

> 
> Ciao,
> Dscho
>