From: Derrick Stolee <derrickstolee@github.com>
Date: Thu, 23 Jun 2022 15:10:58 GMT
Subject: Re: [PATCH v4 6/7] mv: use flags mode for update_mode
Message-ID: <c232ccf7-1f73-030c-b7f8-02bdef342ba4@github.com>
In-Reply-To: <20220623114120.12768-7-shaoxuan.yuan02@gmail.com>

On 6/23/2022 7:41 AM, Shaoxuan Yuan wrote:
> As suggested by Derrick [1],
> move the in-line definition of "enum update_mode" to the top
> of the file and make it use "flags" mode (each state is a different
> bit in the word).

nit: strange line-wrapping here.

> Change the flag assignments from '=' (single assignment) to '|='
> (additive). Also change flag evaluation from '==' to '&', etc.

Code looks good.

Thanks,
-Stolee