From: Johannes Sixt Date: Wed, 29 Jan 2025 07:50:24 GMT Subject: Re: [PATCH v2 15/20] compat: consistently resolve headers via project root Message-ID: In-Reply-To: <20250128-pks-reftable-drop-git-compat-util-v2-15-c85c20336317@pks.im> Am 28.01.25 um 09:28 schrieb Patrick Steinhardt: > diff --git a/compat/fsmonitor/fsm-health-darwin.c b/compat/fsmonitor/fsm-health-darwin.c > index c2afcbe6c8..68c9fd7363 100644 > --- a/compat/fsmonitor/fsm-health-darwin.c > +++ b/compat/fsmonitor/fsm-health-darwin.c > @@ -1,7 +1,7 @@ > #include "git-compat-util.h" > +#include "compat/fsmonitor/fsm-health.h" > #include "config.h" > #include "fsmonitor-ll.h" > -#include "fsm-health.h" > #include "fsmonitor--daemon.h" > > int fsm_health__ctor(struct fsmonitor_daemon_state *state UNUSED) The use of double-quotes #include "fsm-health.h" very clearly indicates "this file is expected to be in the same directory as the file that is including it". On the other hand, #include would state "this file is to be found somewhere on the include paths, but not in the directory of the including file". Therefore, changes like this one, where the new path only points back to the same directory where the including file is, are very much undesirable. The unpatched form is preferable. Depending on the desired goal, is it perhaps better to use <> brackets more liberally? -- Hannes