From: Christian Couder <christian.couder@gmail.com>
Date: Mon, 01 Feb 2010 12:43:57 GMT
Subject: Re: [RFC/PATCH 5/6] revert: add --ff option to allow fast forward when cherry-picking
Message-ID: <c07716ae1002010443p4e0443feke14e5f877584640f@mail.gmail.com>
In-Reply-To: <4B66B68C.7050505@gnu.org>

On Mon, Feb 1, 2010 at 12:10 PM, Paolo Bonzini <bonzini@gnu.org> wrote:
>> +               OPT_BOOLEAN(0, "ff",&ff_ok, "allow fast forward"),
>
> Why should this not be the default?

Maybe it could be the default, but in this case it should be made
compatible with -n option
(and perhaps other options) for backward compatibility, and this would
probably need more
involved changes.

Thanks,
Christian.

> Instead, you'd add --no-ff.  This would
> simplify 6/6 further, like
>
>  eval sha1=\$$#
>  ...
>  output git cherry-pick "$@"
>
> Paolo
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>