From: Jeff Hostetler Date: Mon, 01 Apr 2019 21:06:44 GMT Subject: Re: [PATCH v2 4/7] trace2: use system config for default trace2 settings Message-ID: In-Reply-To: <20190401210034.GD60888@google.com> On 4/1/2019 5:00 PM, Josh Steadmon wrote: > On 2019.03.29 10:04, Jeff Hostetler via GitGitGadget wrote: > [...] >> diff --git a/Documentation/technical/api-trace2.txt b/Documentation/technical/api-trace2.txt >> index baaa1153bb..13ca595c69 100644 >> --- a/Documentation/technical/api-trace2.txt >> +++ b/Documentation/technical/api-trace2.txt >> @@ -117,6 +117,37 @@ values are recognized. >> Socket type can be either `stream` or `dgram`. If the socket type is >> omitted, Git will try both. >> >> +== Trace2 Settings in System Config >> + >> +Trace2 also reads configuration information from the system config. >> +This is intended to help adminstrators to gather system-wide Git >> +performance data. >> + >> +Trace2 only reads the system configuration, it does not read global, >> +local, worktree, or `-c` config settings. >> + >> +Trace2 will try to load the following system configuration settings >> +and then read the corresponding environment variables at startup. >> + >> +.... >> +--------------------------------------------------- >> +trace2.normalTarget GIT_TR2 >> +trace2.normalBrief GIT_TR2_BRIEF >> + >> +trace2.perfTarget GIT_TR2_PERF >> +trace2.perfBrief GIT_TR2_PERF_BRIEF >> + >> +trace2.eventTarget GIT_TR2_EVENT >> +trace2.eventBrief GIT_TR2_EVENT_BRIEF >> +trace2.eventNesting GIT_TR2_EVENT_NESTING >> + >> +trace2.configParams GIT_TR2_CONFIG_PARAMS >> + >> +trace2.destinationDebug GIT_TR2_DST_DEBUG >> +--------------------------------------------------- >> +.... >> + >> + > > A question for the list: should these new config vars also be documented > in the git-config manpage, or is it better to keep these separate since > they are only read from the system config? > I wasn't sure either, so I just kept them in the trace2 api doc for now. Jeff