From: Miles Bader <miles@gnu.org>
Date: Wed, 14 Dec 2011 05:23:29 GMT
Subject: Re: [PATCH resend] Do not create commits whose message contains NUL
Message-ID: <buomxavwwtq.fsf@dhlpc061.dev.necel.com>
In-Reply-To: <20111213175932.GA1663@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:
>      But maybe it would be nicer to say something like:
>
>        error: your commit message contains NUL characters.
>        hint: This is often caused by using multibyte encodings such as
>        hint: UTF-16. Please check your editor settings.

I think the error message with the hint is much better for users, but
isn't the term "multibyte" a little misleading here?  It seems like
it's really _wide_ encodings that are generally the culprit.

[UTF-16 of course is particularly nasty in that it uses both units which
are wider than a byte ("wide"), _and_ multiple units per code-point....]

Thanks,

-Miles

-- 
Quack, n. A murderer without a license.