From: Brandon Casey Date: Sat, 20 Mar 2010 00:10:20 GMT Subject: [PATCH 3/3 resend] t/t5505-remote.sh: escape * to prevent interpretation by shell as glob Message-ID: In-Reply-To: From: Brandon Casey This test is supposed to check that git-remote correctly refuses to delete all URLS for the specified remote which match the '.*' regular expression. Since the '*' was not protected, it was interpreted by the shell as a file glob and expanded before being passed to git-remote. The call to git-remote still exited non-zero in this case, and the overall test still passed, but it exited non-zero because git-remote was passed the incorrect number of arguments, not for the reason it was supposed to fail. Correct the test by escaping the '*'. Signed-off-by: Brandon Casey --- Well, since I don't know if the origin 3/3 was lost or whether I accidentally hit 'n' when git-send-email prompted me for whether to send it, here it is again. -brandon t/t5505-remote.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/t/t5505-remote.sh b/t/t5505-remote.sh index e7afe9e..acfea06 100755 --- a/t/t5505-remote.sh +++ b/t/t5505-remote.sh @@ -662,7 +662,7 @@ test_expect_success 'remote set-url --add bbb' ' ' test_expect_success 'remote set-url --delete .*' ' - test_must_fail git remote set-url --delete someremote .* && + test_must_fail git remote set-url --delete someremote .\* && echo "YYY" >expect && echo baz >>expect && echo bbb >>expect && -- 1.6.6.2