From: Derrick Stolee <stolee@gmail.com>
Date: Fri, 29 Jun 2018 14:53:10 GMT
Subject: Re: [PATCH v3 00/32] object-store: lookup_commit
Message-ID: <be744bdb-5a98-8b38-37e1-3d5847e5fbf1@gmail.com>
In-Reply-To: <20180629012222.167426-1-sbeller@google.com>

On 6/28/2018 9:21 PM, Stefan Beller wrote:
> This continues the elimination of global variables in the object store and
> teaches lookup_commit[_reference] and alike to handle a_repository.
>
> This is also available as
> https://github.com/stefanbeller/git/tree/object-store-lookup-commit
> or applies on top of 02f70d63027 (Merge branch 'sb/object-store-grafts'
> into next, 2018-06-28).
>
> Picking a base for this one is really hard, as nearly all series currently
> cooking or in flight collide with it on one or two lines. (lookup_* is used
> heavily, who would have thought?); I really needed 'sb/object-store-grafts'
> to build on; and there is only one other series before that in current next,
> which this series would have conflicted with, if not based on top of it.
>
> In "The state of the object store series" [1], this was tentatively named
> "sb/object-store-lookup".

As usual, this series was easy to review. It has a few places where it 
conflicts with ds/commit-graph-fsck, but they are not hard to resolve. I 
created a merge commit between that branch and your version of this 
series [1]. It passes all tests on my machine.

Thanks,

-Stolee

[1] 
https://github.com/derrickstolee/git/commits/commit-graph-fsck-and-object-store