From: Tay Ray Chuan <rctay89@gmail.com>
Date: Mon, 10 Aug 2009 15:47:20 GMT
Subject: Re: [PATCH] Check return value of ftruncate call in http.c. Remove possible mem leak
Message-ID: <be6fef0d0908100847h7e9b53a2ofdf318e9958be3b2@mail.gmail.com>
In-Reply-To: <1249911747-28490-1-git-send-email-jeff.lasslett@gmail.com>

Hi,

On Mon, Aug 10, 2009 at 9:42 PM, Jeff Lasslett<jeff.lasslett@gmail.com> wrote:
> @@ -1216,10 +1220,12 @@ struct http_object_request *new_http_object_request(const char *base_url,
>                                 CURLOPT_HTTPHEADER, range_header);
>        }
>
> +       free(url);
>        return freq;
>
> -       free(url);

Freeing after the return didn't make sense. Thanks for spotting this.

On a side note, you could simply do away with the 'url' variable,
since you're going to pass freq->url to curl_setopt.

-- 
Cheers,
Ray Chuan