From: Tay Ray Chuan Date: Sun, 07 Jun 2009 10:31:38 GMT Subject: Re: [Patch] Prevent cloning over http from spewing Message-ID: In-Reply-To: <20090604160152.GA13984@sigill.intra.peff.net> Hi, On Fri, Jun 5, 2009 at 12:01 AM, Jeff King wrote: > Thanks, I took a look at starting on a progress meter yesterday, but I > do think it makes sense to integrate with the work you are doing. > > I tried your http-progress-indicators branch. A few comments: > >  1. You still end up with a lot of lines of output. Some of those are >     "Getting pack $x" which we can probably get rid of in non-verbose >     mode. But we still get a different progress indicator line for each >     fetched item, which can add up to quite a lot. I was thinking of >     something like > >        Fetching %s (got %d packs, %d loose): (%d/%d) > >     with the substitutions: > >       %s = "pack", "index", or "loose object" >       %d packs, %d loose = a running count of how much we've gotten >       %d/%d = current and total byte counts for what we are getting now > >     and then you could keep everything on a single line. I don't think >     is possible with the current progress code (it doesn't let you >     restart the counter), but it should be easy with some tweaking. Hmm, just wondering, is this is the intended display for "-q" or "-v"? Or should I do isatty(), like builtin-pack-objects.c does for the "Writing objects" progress indicator? -- Cheers, Ray Chuan