From: Tay Ray Chuan Date: Sun, 01 Mar 2009 09:33:02 GMT Subject: Re: coding style: #ifdef blocks and real C blocks Message-ID: In-Reply-To: <7vbpsl8v7r.fsf@gitster.siamese.dyndns.org> On Sun, Mar 1, 2009 at 5:10 PM, Junio C Hamano wrote: >    #ifdef USE_CURL_MULTI >    #define active_slot_get get_active_multi_slot >    #else >    #define active_slot_get get_active_slot >    #endif > > so that the code itself would not have to have any #ifdef? On further thought, wouldn't it be a better idea to make this uppercase, ie. GET_ACTIVE_SLOT, to make it more obvious this is a macro? Then we wouldn't have to jumble the name into "active_slot_get" to differentiate it from the two slot functions. -- Cheers, Ray Chuan