From: Sebastian Schuberth Date: Fri, 25 Sep 2009 22:45:51 GMT Subject: Re: [PATCH 1/2] Make generated MSVC solution file open from Windows Explorer Message-ID: In-Reply-To: <81b0412b0909251511m24e5c6bcg3f8c4e3576ad3bd3@mail.gmail.com> On Sat, Sep 26, 2009 at 00:11, Alex Riesen wrote: > On Sat, Sep 26, 2009 at 00:05, Shawn O. Pearce wrote: >> Sebastian Schuberth wrote: >>> In order to be able to open the generated solution file by double-clicking it >>> in Windows Explorer, all project files need to use DOS line-endings and a >>> comment about the Visual Studio version needs to be added to the header of the >>> solution file. This also fixes the icon that is displayed for the solution file >>> in Windows Explorer. >>> Note that opening the solution file from a running instance of Visual Studio >>> already worked before. >> >> Something is wrong with both patches; neither applies.  It looks >> to be an issue with whitespace, like context lines are gaining an >> extra space at the start of the line. > > Besides, there is PERLIO environment variable. Try setting it to > PERLIO=':perlio' But I don't feel like using it here would be the right thing to do. Visual Studio project files should never ever be written out with Unix line-endings, not even if someone created them under Unix. So instead of relying on the environment variable to be set correctly, I believe it's better to always enforce the correct line-endings here. -- Sebastian Schuberth