From: Josh Steadmon <steadmon@google.com>
Date: Thu, 08 Jan 2026 22:30:47 GMT
Subject: Re: [PATCH v8 00/11] Add submodulePathConfig extension and gitdir encoding
Message-ID: <bd2wmyi5pq5rd5l23nsk7d6lp3q4664omkq4pfjuwlcdkcajr3@v2c7vsfv2hxa>
In-Reply-To: <aV9S_oUJjitkeWjo@pks.im>

On 2026.01.08 07:47, Patrick Steinhardt wrote:
> On Thu, Jan 08, 2026 at 01:01:34AM +0200, Adrian Ratiu wrote:
> > Changes in v8:
> > * Added a new test to ensure gitdir config path is relative (Patrick)
> > * Improved gitdir validation error message and added advice (Patrick)
> > * Renamed init.autoSetupSubmodulePathConfig to init.defaultSubmodulePathConfig
> >   and moved its init logic to initialize_repository_version() (Patrick)
> > * repositoryformatversion is only set to 1 if it's 0, so it doesn't
> >   overwrite potential future higher versions (Patrick)
> > * Fixed global init.defaultSubmodulePathConfig leak between tests (Adrian)
> > * Whitespace and other minor fixes (Junio, Patrick)
> 
> I've had two more small comments, but other than that this version looks
> good to me. Thanks!
> 
> Patrick

Disclaimer for the list: my employer is funding Adrian's work on this
series.

I've tested this locally, and I'm convinced that this can replace our
downstream version of this feature without requiring user toil or
disruption.

Thanks Adrian for your work on this!

This looks good to me too (modulo Patrick's comments, which I agree
with).