From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Mon, 09 Apr 2018 16:49:35 GMT
Subject: Re: What's cooking in git.git (Apr 2018, #01; Mon, 9)
Message-ID: <bba6e3ba-ab28-8cda-eab3-91ec3591bcb5@ramsayjones.plus.com>
In-Reply-To: <98394864-ece6-5112-0274-b2399087f207@gmail.com>



On 09/04/18 14:37, Derrick Stolee wrote:
> On 4/9/2018 6:21 AM, Junio C Hamano wrote:
>> * ds/commit-graph (2018-04-02) 16 commits
>>   - commit-graph: implement "--additive" option
>>   - commit-graph: build graph from starting commits
>>   - commit-graph: read only from specific pack-indexes
>>   - commit: integrate commit graph with commit parsing
>>   - commit-graph: close under reachability
>>   - commit-graph: add core.commitGraph setting
>>   - commit-graph: implement git commit-graph read
>>   - commit-graph: implement git-commit-graph write
>>   - commit-graph: implement write_commit_graph()
>>   - commit-graph: create git-commit-graph builtin
>>   - graph: add commit graph design document
>>   - commit-graph: add format document
>>   - csum-file: refactor finalize_hashfile() method
>>   - csum-file: rename hashclose() to finalize_hashfile()
>>   - Merge branch 'jk/cached-commit-buffer' into HEAD
>>   - Merge branch 'jt/binsearch-with-fanout' into HEAD
>>   (this branch is used by ds/lazy-load-trees.)
>>
>>   Precompute and store information necessary for ancestry traversal
>>   in a separate file to optimize graph walking.
>>
>>   Ready???
>>   It seems that this topic is getting there.
> 
> I think this patch is ready to go, barring the edit of "--additive" to "--append" in the final commit message and squashing following diff into "commit-graph: implement git commit-graph read":
> 
> @@ -31,7 +31,7 @@ static struct opts_commit_graph {
> 
>  static int graph_read(int argc, const char **argv)
>  {
> -       struct commit_graph *graph = 0;
> +       struct commit_graph *graph = NULL;
>         char *graph_name;
> 
>         static struct option builtin_commit_graph_read_options[] = {
> 

Also, it seems that the 'static' keyword has been dropped from the
declaration of 'commit_graph' (commit-graph.c #183) again:

  $ diff nsp-out psp-out
  18a19
  >     SP chdir-notify.c
  23a25,26
  >     SP commit-graph.c
  > commit-graph.c:183:21: warning: symbol 'commit_graph' was not declared. Should it be static?
  66a70
  >     SP json-writer.c
  209a214,215
  >     SP builtin/commit-graph.c
  > builtin/commit-graph.c:34:38: warning: Using plain integer as NULL pointer
  299d304
  < fast-import.c:303:40: warning: Using plain integer as NULL pointer
  312a318
  >     SP t/helper/test-json-writer.c
  315a322
  >     SP t/helper/test-print-larger-than-ssize.c
  $ 

ATB,
Ramsay Jones