From: Alexander Gavrilov Date: Wed, 17 Sep 2008 12:25:47 GMT Subject: Re: [PATCH/RFC 2/2] git-gui: Do not automatically stage file after merge tool finishes Message-ID: In-Reply-To: <1221651652-3712-3-git-send-email-johannes.sixt@telecom.at> On Wed, Sep 17, 2008 at 3:40 PM, Johannes Sixt wrote: > If a merge tool was invoked on a conflicted file and the tool completed, > then the conflicted file was staged automatically. However, the fact that > the user closed the merge tool cannot be understood as the unequivocal > sign that the conflict was completely resolved. For example, the user > could have decided to postpone the resolution of the conflict, or could > have accidentally closed the tool. We better leave the file unstaged and > let the user stage it explicitly. It completely reproduces the logic that git-mergetool uses. Namely, if the file is unchanged, it asks explicitly, and if the tool returns a non-zero exit code, it does not stage at all. You also cannot simply remove merge_add_resolution, because then it would leave the diff view stale.