From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Wed, 10 Aug 2016 17:13:29 GMT
Subject: Re: [PATCH 5/8] xdl_change_compact(): fix compaction heuristic to adjust io
Message-ID: <badb2c5b-e2da-03d0-e315-7b92659bb464@alum.mit.edu>
In-Reply-To: <xmqqshuk2x3p.fsf@gitster.mtv.corp.google.com>

On 08/04/2016 08:43 PM, Junio C Hamano wrote:
> Michael Haggerty <mhagger@alum.mit.edu> writes:
> 
>> The code branch used for the compaction heuristic incorrectly forgot to
>> keep io in sync while the group was shifted. I think that could have
>> led to reading past the end of the rchgo array.
> 
> I had to read the first sentence three times as "incorrectly forgot"
> was a bit strange thing to say (as if there is a situation where
> 'forgetting to do' is the correct thing to do, but in that case we
> would phrase it to stress that not doing is a deliberate choice,
> e.g. 'refraining from doing').  Perhaps s/incorrectly // is the
> simplest readability improvement?

Yes, that makes it clearer. Will change.

Michael