From: Kaartic Sivaraam Date: Wed, 20 May 2020 13:12:48 GMT Subject: Re: [PATCH v2] submodule: port subcommand 'set-branch' from shell to C Message-ID: In-Reply-To: <20200520121530.GA7992@konoha> Hi Shourya, On 20-05-2020 17:45, Shourya Shukla wrote: > On 19/05 02:57, Eric Sunshine wrote: >> On Tue, May 19, 2020 at 2:27 PM Shourya Shukla >> wrote: >>> + if (opt_branch && opt_default) >>> + die(_("--branch and --default do not make sense together")); >> >> A more precise way to say this is: >> >> die(_("--branch and --default are mutually exclusive")); > > Will that be clear to everyone? What I mean is maybe a person from a > non-mathematical background (someone doing programming as a hobby maybe) > will not grasp at this at one go and will have to search it's meaning > online. Isn't it fine as-is? > While "mutually exclusive" might be prominently used in mathematics. I don't think it is only understandable by people with a mathematical background. Moreover, I see 183 results in 36 files for "mutually exclusive" in git.git (including translation files). So, this isn't anything new. I agree with Eric's suggestion. It makes the error message concise which is a nice side benefit. -- Sivaraam