From: lilinchao@oschina.cn <lilinchao@oschina.cn>
Date: Thu, 13 May 2021 08:17:54 GMT
Subject: Re: Re: [PATCH] builtin/gc: warn when core.commitGraph is disabled
Message-ID: <b87b12b4b3c311eba1fd0024e87935e7@oschina.cn>
In-Reply-To: <87tunau7ia.fsf@evledraar.gmail.com>


>
>On Mon, May 10 2021, lilinchao@oschina.cn wrote:
>
>> From: Li Linchao <lilinchao@oschina.cn>
>>
>> Throw warning message when core.commitGraph is disabled in commit-graph
>> maintenance task.
>
>Won't this cause the gc.log issue noted in
>https://lore.kernel.org/git/87r1l27rae.fsf@evledraar.gmail.com/
>
>More importantly, I don't think this UX makes sense. We said we didn't
>want it, so why warn about it?
>
>Maybe there are good reasons to, but this commit message / patch doesn't
>make the case for it...
>
Uh, well, maybe I should argue for this patch a bit more.

First this is in git maintenance task, I've read the link you post, and I feel it has nothing to do with maintenance task.

Second I hope the `commit-graph` task can do the same thing with `incremental repack` task that to warn user when the related necessary setting is not yet ready, instead of running quietly, but doing nothing.

Thanks